Skip to content

chore: update Kysely version in driver package #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

MaxMonteil
Copy link
Contributor

Kysely recently release a new version 0.28 and I would like to add support for it in Powersync.

Currently, updating Kysely alone throws a bunch of type errors.

This is my first contribution attempt to Powersync, please let me know what other changes and information I can provide to help get this PR merged!

Copy link

changeset-bot bot commented Apr 13, 2025

🦋 Changeset detected

Latest commit: 6a185a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@powersync/kysely-driver Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan
Copy link
Contributor

Chriztiaan commented Apr 14, 2025

Hey @MaxMonteil, thanks for raising this! Normally when making a change to a package we would use pnpm changeset to ensure a changeset entry that describes the change to the package. In this case it might be making changes to the API so a minor bump instead of a patch could be considered.

And then since you made a package.json change, running pnpm install and checking in the lock file change would be appreciated.

We'll also just need to ensure that you ran the tests on your side, we currently don't run automatic builds from forked PRS.


EDIT: I added those changes so that you have a reference for next time :)

@MaxMonteil
Copy link
Contributor Author

Thanks a bunch @Chriztiaan 🙏🏾 , sorry for just now replying, had a busy week 🫠

First time using pnpm so TIL!

I had some trouble with the workspace package install and ended up first creating an empty PR hence that first message, apologies about the mess.

The tests ran successfully on my side, is there a specific thing I can include to show that?

Otherwise I see another review is the last thing missing, lemme know if there's anything else I can contribute.

@Chriztiaan Chriztiaan requested a review from simolus3 April 22, 2025 06:21
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran tests for this locally, so LGTM 👍

@Chriztiaan Chriztiaan merged commit d0d0c02 into powersync-ja:main Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants