-
Notifications
You must be signed in to change notification settings - Fork 44
chore: update Kysely version in driver package #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6a185a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @MaxMonteil, thanks for raising this! Normally when making a change to a package we would use And then since you made a We'll also just need to ensure that you ran the tests on your side, we currently don't run automatic builds from forked PRS. EDIT: I added those changes so that you have a reference for next time :) |
Thanks a bunch @Chriztiaan 🙏🏾 , sorry for just now replying, had a busy week 🫠 First time using I had some trouble with the workspace package install and ended up first creating an empty PR hence that first message, apologies about the mess. The tests ran successfully on my side, is there a specific thing I can include to show that? Otherwise I see another review is the last thing missing, lemme know if there's anything else I can contribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also ran tests for this locally, so LGTM 👍
Kysely recently release a new version 0.28 and I would like to add support for it in Powersync.
Currently, updating Kysely alone throws a bunch of type errors.
This is my first contribution attempt to Powersync, please let me know what other changes and information I can provide to help get this PR merged!